Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration/resource handling in activity contexts #7692

Merged
merged 0 commits into from Oct 8, 2022

Conversation

copybara-service[bot]
Copy link

Fix configuration/resource handling in activity contexts

A few fixes to address correct behavior of configuration and resources when using activity contexts:

  • Create the activity token before creating the activity context and correctly pass it in instead of passing in the null token from the base context, this is necessary as the context uses the token to key resources so using a null token results in activities using incorrect asset managers
  • Pass through a correct override config when creating the activity context, most of the time the override config can safely be null and just inherit from the application but when explicitly configuring resources on an activity during configuration change we should pass in the request override
  • Trigger activity configuration change for ActivityScenario (i.e. those created by the instrumentation) activities based on the application resources changing configuration rather than the static system ones, applications generally expect the application configuration to be consistent with the activity resources and RuntimeEnvironment is configuring the application resource configurations after the system ones so triggering on the system ones was too early.

@copybara-service copybara-service bot closed this Oct 8, 2022
@copybara-service copybara-service bot merged commit d9fc79d into google Oct 8, 2022
@copybara-service copybara-service bot deleted the piper_479515487 branch October 8, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants