Only filter sdk when PREINSTRUMENTED_SDK_VERSIONS is not empty #7787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utzcoz
force-pushed
the
fix-preinstrumented-instrumentAll-building-error
branch
2 times, most recently
from
51207a3
to
ec88d79
Compare
This CL can fix building error when PREINSTRUMENTED_SDK_VERSIONS is empty/not set when running command `./gradlew :preinstrumented:instrumentAll`. I tested it locally with following two commands: ./gradlew :preinstrumented:instrumentAll PREINSTRUMENTED_SDK_VERSIONS=33 ./gradlew :preinstrumented:instrumentAll Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
utzcoz
force-pushed
the
fix-preinstrumented-instrumentAll-building-error
branch
from
ec88d79
to
d1bd0a8
Compare
hoisie
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL can fix building error when PREINSTRUMENTED_SDK_VERSIONS is empty/not set when running command
./gradlew :preinstrumented:instrumentAll.I tested it locally with following two commands: