Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future proof ShadowViewGroupTest#hasFocus_shouldReturnTrueIfAnyChildHasFocus. #8034

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Future proof ShadowViewGroupTest#hasFocus_shouldReturnTrueIfAnyChildHasFocus. #8034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 62 additions & 21 deletions robolectric/src/test/java/org/robolectric/shadows/ShadowViewGroupTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
import android.app.Application;
import android.content.Context;
import android.graphics.Bitmap;
import android.graphics.Bitmap.Config;
import android.graphics.Canvas;
import android.os.Bundle;
import android.view.MotionEvent;
import android.view.View;
import android.view.ViewGroup;
Expand All @@ -24,6 +24,7 @@
import android.view.animation.LayoutAnimationController;
import android.widget.FrameLayout;
import android.widget.TextView;
import androidx.annotation.Nullable;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import java.io.ByteArrayOutputStream;
Expand All @@ -34,6 +35,7 @@
import org.junit.runner.RunWith;
import org.robolectric.R;
import org.robolectric.Robolectric;
import org.robolectric.annotation.Config;

@RunWith(AndroidJUnit4.class)
public class ShadowViewGroupTest {
Expand Down Expand Up @@ -182,32 +184,71 @@ public void shouldfindViewWithTagFromCorrectViewGroup() {
}

@Test
@Config(minSdk = 17) // TODO: mysteriously fails on github CI on API 16
public void hasFocus_shouldReturnTrueIfAnyChildHasFocus() {
makeFocusable(root, child1, child2, child3, child3a, child3b);
assertFalse(root.hasFocus());
ContainerActivity containerActivity = Robolectric.setupActivity(ContainerActivity.class);
makeFocusable(
containerActivity.root,
containerActivity.child1,
containerActivity.child2,
containerActivity.child3,
containerActivity.child3a,
containerActivity.child3b);

child1.requestFocus();
assertTrue(root.hasFocus());
containerActivity.child1.requestFocus();
assertTrue(containerActivity.root.hasFocus());

child1.clearFocus();
assertFalse(child1.hasFocus());
assertTrue(root.hasFocus());
containerActivity.child1.clearFocus();
assertFalse(containerActivity.child1.hasFocus());
assertTrue(containerActivity.root.hasFocus());

child3b.requestFocus();
assertTrue(root.hasFocus());
containerActivity.child3b.requestFocus();
assertTrue(containerActivity.root.hasFocus());

child3b.clearFocus();
assertFalse(child3b.hasFocus());
assertFalse(child3.hasFocus());
assertTrue(root.hasFocus());
containerActivity.child3b.clearFocus();
assertFalse(containerActivity.child3b.hasFocus());
assertFalse(containerActivity.child3.hasFocus());
assertTrue(containerActivity.root.hasFocus());

child2.requestFocus();
assertFalse(child3.hasFocus());
assertTrue(child2.hasFocus());
assertTrue(root.hasFocus());
containerActivity.child2.requestFocus();
assertFalse(containerActivity.child3.hasFocus());
assertTrue(containerActivity.child2.hasFocus());
assertTrue(containerActivity.root.hasFocus());

root.requestFocus();
assertTrue(root.hasFocus());
containerActivity.root.requestFocus();
assertTrue(containerActivity.root.hasFocus());
}

private static class ContainerActivity extends Activity {

ViewGroup root;
View child1;
View child2;
ViewGroup child3;
View child3a;
View child3b;

@Override
protected void onCreate(@Nullable Bundle savedInstanceState) {
super.onCreate(savedInstanceState);

root = new FrameLayout(this);

child1 = new View(this);
child2 = new View(this);
child3 = new FrameLayout(this);
child3a = new View(this);
child3b = new View(this);

root.addView(child1);
root.addView(child2);
root.addView(child3);

child3.addView(child3a);
child3.addView(child3b);

setContentView(root);
}
}

@Test
Expand Down Expand Up @@ -455,7 +496,7 @@ public void draw_drawsChildren() {
DrawRecordView view = new DrawRecordView(context);
ViewGroup viewGroup = new FrameLayout(context);
viewGroup.addView(view);
Bitmap bitmap = Bitmap.createBitmap(100, 100, Config.ARGB_8888);
Bitmap bitmap = Bitmap.createBitmap(100, 100, Bitmap.Config.ARGB_8888);
Canvas canvas = new Canvas(bitmap);
viewGroup.draw(canvas);
assertThat(view.wasDrawn).isTrue();
Expand Down