Create separate sandboxes for different graphics modes #8082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_518349097
branch
from
4633ae4
to
c32bd81
Compare
Previously, graphics shadow invalidation did not occur. When the graphics mode switched, graphics shadows that had already been picked were reused. This meant that transitions between graphics modes were very likely to cause segfaults, as transitions between modes would result in a mixture of legacy and native graphics shadow classes being used. Add a new sandbox param for graphics mode. This will result in a separate set of sandboxes to be created when the graphics mode switches. RE #8073 PiperOrigin-RevId: 518483054
copybara-service
bot
force-pushed
the
piper_518349097
branch
from
c32bd81
to
2ca4753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create separate sandboxes for different graphics modes
Previously, graphics shadow invalidation did not occur. When the graphics
mode switched, graphics shadows that had already been picked were reused. This
meant that transitions between graphics modes were very likely to cause
segfaults, as transitions between modes would result in a mixture of legacy and
native graphics shadow classes being used.
Add a new sandbox param for graphics mode. This will result in a separate set
of sandboxes to be created when the graphics mode switches.
RE #8073