Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Matrix.setValues to be called with array size >9. #8371

Merged

Conversation

zach-klippenstein
Copy link
Contributor

If the array is <9, and ArrayIndexOutOfBoundsException is still thrown.

Tested by new tests in ShadowMatrixTest.

Fixes #8369

If the array is <9, and ArrayIndexOutOfBoundsException is still thrown.

Tested by new tests in `ShadowMatrixTest`.

Fixes robolectric#8369
Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@utzcoz utzcoz requested a review from hoisie July 27, 2023 02:44
@utzcoz utzcoz merged commit 8174aad into robolectric:master Jul 27, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matrix.setValues doesn't accept value array with size >9
2 participants