support for queryIntentActivities(Intent intent, ResolveInfoFlags flags) of Android 13 #8409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utzcoz
requested changes
Aug 15, 2023
shadows/framework/src/main/java/org/robolectric/shadows/ShadowApplicationPackageManager.java
Outdated
Show resolved
Hide resolved
|
@qq549631030 Please squash to one commit and fix code formatting. |
utzcoz
reviewed
Aug 16, 2023
shadows/framework/src/main/java/org/robolectric/shadows/ShadowApplicationPackageManager.java
Outdated
Show resolved
Hide resolved
shadows/framework/src/main/java/org/robolectric/shadows/ShadowApplicationPackageManager.java
Show resolved
Hide resolved
|
@qq549631030 Please add the commit message body. |
utzcoz
reviewed
Aug 16, 2023
shadows/framework/src/main/java/org/robolectric/shadows/ShadowApplicationPackageManager.java
Outdated
Show resolved
Hide resolved
… flags) Delegates the new queryIntentActivitiesAsUser(Intent,ResolveInfoFlags,int) to queryIntentActivities(Intent, int)
|
@hoisie Please take an extra look, LGTM. |
utzcoz
approved these changes
Aug 18, 2023
|
@qq549631030 Thanks for your contribution. |
|
This is quite delayed and I hesitate to generate a notification reporting success, but I will do so and take the opportunity to express my apprecation again to @qq549631030 for the PR. I finally had a chance to test this, so I pulled 4.11-SNAPSHOT and it tested fine in my use case. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8215.