Double duration of awaitFinalized in ShadowThemeTest

[utzcoz]

Looks like shouldFreeNativeObjectInRegistry becomes flaky with JDK17 sometimes on GitHub Actions.

[utzcoz]

cc @hoisie .

[utzcoz]

From testing result, looks like this PR reduces the flaky percentage, but this test case also flaky. @hoisie Maybe you can help to select a higher duration?

[hoisie]

Guava has GCfinalization.awaitClear, maybe that works better?

We can also move this to MemoryLeaksTest which generates an hprof when run inside Google.

[utzcoz]

@hoisie I can give a try tomorrow. I just updated it again to 15s to make everything stable, at least it is stable with my some PRs testing.

[utzcoz]

@hoisie GCfinalization.awaitClear uses max 10s to wait the object to be GCed: https://github.com/google/guava/blob/4478b7f5ee8fbc63a3071b058abc876d2d192e85/guava-testlib/src/com/google/common/testing/GcFinalization.java#L117. But from my experience, 10s is not enough for the Robolectric's occasion.

[hoisie]

This test was still flaky so I moved it to MemoryLeaksTest: c90c030

Internally at Google I ran it thousands of times and there wasn't a single flake.

I'll keep an eye on it.

[utzcoz]

@hoisie I think it is only flaky when running it on GitHub Actions environment. Maybe it is related to GitHub Actions environment's restriction as objects are recycled very late than expected not leaked. At least, we can retrigger it if flaky on GitHub Actions.

[hoisie]

@utzcoz MemoryLeaksTest seems to run reliably on GitHub CI. That test uses Guava's GCFinalization assertions. I assume that Guava's GCFinalization probably handles some subtle edge cases that were not handled by the awaitFinalized in ShadowThemeTest.

[hoisie]

In retrospect this may actually be a race condition. I know calling System.gc() will create a separate finalizer thread. Maybe there is a race between when this thread completes and when the assertions occur on the test thread.

[utzcoz]

@hoisie Maybe. The test suite of the memoryleak module is not large, and maybe it will cause flaky issues as you said. Could you merge google branch into master branch recently? I want the master branch to benefit from this change too.