Refactor ShadowCamera to use more real Android code #8519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_572018420
branch
2 times, most recently
from
9c9693c
to
4ad852c
Compare
Camera.Parameters and Camera.Size are pure Java classes, yet were reimplemented using shadow methods in Robolectric. Update the shadows to use as much real Android code as possible. Also update the shadow APIs to just invoke Android API methods. PiperOrigin-RevId: 572806961
copybara-service
bot
force-pushed
the
piper_572018420
branch
from
4ad852c
to
460db5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ShadowCamera to use more real Android code
Camera.Parameters and Camera.Size are pure Java classes, yet were reimplemented
using shadow methods in Robolectric. Update the shadows to use as much real
Android code as possible. Also update the shadow APIs to just invoke Android
API methods.