Add shadow for AlwaysOnHotwordDetector #8536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_572953926
branch
6 times, most recently
from
418ded4
to
62c1923
Compare
copybara-service
bot
force-pushed
the
piper_572953926
branch
from
62c1923
to
01e4441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shadow for AlwaysOnHotwordDetector
The goal of this change is to allow testing of a VoiceInteractionService that calls createAlwaysOnHotwordDetector and have the detector return true when startRecognition is called.
I've removed some unneeded shadowing in ShadowVoiceInteractionService in favor of real code. For the detector, there are two critical fields that I'm now setting when the object is created. Note that a test hoping to achieve this result should also provide some fake metadata in its manifest to convince KeyphraseEnrollmentInfo that an enrollment apk is present.