Fix RecordingCanvas.nFinishRecording for Q and R #8690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
piper_590691719
branch
from
4197945
to
c6c277e
Compare
Previously, the native RecordingCanvas.nFinishRecording was a no-op for Q and R. Add an implementation that calls into the S version of nFinishRecording. To do this, we need to keep track of the current render nodes associated with recording canvases. PiperOrigin-RevId: 590958477
copybara-service
bot
force-pushed
the
piper_590691719
branch
from
c6c277e
to
9ce906d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RecordingCanvas.nFinishRecording for Q and R
Previously, the native RecordingCanvas.nFinishRecording was a no-op for Q and
R. Add an implementation that calls into the S version of nFinishRecording. To
do this, we need to keep track of the current render nodes associated with
recording canvases.