Clear Choreographer.getInstance for all Loopers. #8884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_607398707
branch
from
200254e
to
32f6f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear Choreographer.getInstance for all Loopers.
Previously Robolectric would attempt to clear Choreographer.getInstance in a resetter method.
However, the Choreographer instance is a ThreadLocal, so when the resetter would have no effect when
running in INSTRUMENTATION_TEST LooperMode, or if a Choreographer was used on another Looper thread.
This can lead to hard-to-debug test pollution issues where Choreographer vsync callbacks don't occur as expected.
This commit changes the reset logic to clear Choreographer.getInstance for all active Looper threads.