Fix edge-to-edge enforcement check in ShadowCompatibility #9035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_629221918
branch
from
cc3a2ac
to
da5e70d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix edge-to-edge enforcement check in ShadowCompatibility
Apps that target Android V and above will be required to support edge-to-edge
content, where apps will be responsible for drawing content under the status
and navigation bars:
https://developer.android.com/about/versions/15/behavior-changes-15#edge-to-edge
In framework code, this is primarily detected using
CompatChanges.isChangeEnabled(ENFORCE_EDGE_TO_EDGE). However, this previously
always returned true because CompatChanges.isChangeEnabled returns true by
default in Robolectric.
In real Android, CompatChanges.isChangeEnabled(ENFORCE_EDGE_TO_EDGE) only
returns true when the target SDK is V or above.