Allow the configs parameter for eglChooseConfig to be null in shadow #9065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the configs parameter for eglChooseConfig to be null in shadow
Most of the time, the output parameters for EGL methods are
expected to be non-null. But the
configs
parameter ofeglChooseConfig
is one of the exceptions. Whenconfigs
isnot null,
eglChooseConfig
fills that with the firstconfigSize
configs and fillsnumConfig
with the number ofreturned configs (no more than
configsSize
). But whenconfigs
is_
null
it fillsnumConfigs
with the number of matchingconfigs, ignoring
configsSize
:https://registry.khronos.org/EGL/sdk/docs/man/html/eglChooseConfig.xhtml
The Android code wrapping this API checks that
attrib_list
andnum_configs
output arrays are not null, but allowsconfigs
to be null (see frameworks/base/core/jni/android_opengl_EGL14.cpp).