Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the configs parameter for eglChooseConfig to be null in shadow #9065

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented May 8, 2024

Allow the configs parameter for eglChooseConfig to be null in shadow

Most of the time, the output parameters for EGL methods are
expected to be non-null. But the configs parameter of
eglChooseConfig is one of the exceptions. When configs is
not null, eglChooseConfig fills that with the first
configSize configs and fills numConfig with the number of
returned configs (no more than configsSize). But when configs
is_ null it fills numConfigs with the number of matching
configs, ignoring configsSize:
https://registry.khronos.org/EGL/sdk/docs/man/html/eglChooseConfig.xhtml

The Android code wrapping this API checks that attrib_list and
num_configs output arrays are not null, but allows configs
to be null (see frameworks/base/core/jni/android_opengl_EGL14.cpp).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants