Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ShadowSpeechRecognizer on Android V #9066

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix for ShadowSpeechRecognizer on Android V #9066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions robolectric/src/test/java/org/robolectric/shadows/ShadowSpeechRecognizerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import android.util.Log;
import androidx.test.core.app.ApplicationProvider;
import java.util.ArrayList;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand All @@ -42,6 +43,11 @@ public void setUp() {
supportCallback = new TestRecognitionSupportCallback();
}

@After
public void tearDown() {
speechRecognizer.destroy();
}

@Test
public void onErrorCalled() {
startListening();
Expand Down Expand Up @@ -118,6 +124,7 @@ public void startAndStopListening() {
shadowOf(speechRecognizer).triggerOnResults(new Bundle());
speechRecognizer.stopListening();

shadowOf(getMainLooper()).idle();
assertNoErrorLogs();
}

Expand All @@ -136,6 +143,8 @@ public void startListeningThenDestroyAndStartListening() {
/** Verify the startlistening flow works when using custom component name. */
@Test
public void startListeningWithCustomComponent() {
speechRecognizer.destroy();

speechRecognizer =
SpeechRecognizer.createSpeechRecognizer(
ApplicationProvider.getApplicationContext(),
Expand All @@ -157,6 +166,7 @@ public void getLatestSpeechRecognizer() {
shadowOf(getMainLooper()).idle();
assertThat(ShadowSpeechRecognizer.getLatestSpeechRecognizer())
.isSameInstanceAs(newSpeechRecognizer);
newSpeechRecognizer.destroy();
}

@Test
Expand All @@ -170,6 +180,7 @@ public void getLastRecognizerIntent() {
newSpeechRecognizer.startListening(intent);
shadowOf(getMainLooper()).idle();
assertThat(shadowOf(newSpeechRecognizer).getLastRecognizerIntent()).isEqualTo(intent);
newSpeechRecognizer.destroy();
}

private void startListening() {
Expand Down Expand Up @@ -236,6 +247,7 @@ public void onRmsChanged(float rmsdB) {
@Config(minSdk = TIRAMISU)
@Test
public void onCreateOnDeviceRecognizer_setsLatestSpeechRecognizer() {
speechRecognizer.destroy();
speechRecognizer = SpeechRecognizer.createOnDeviceSpeechRecognizer(applicationContext);

assertThat(speechRecognizer)
Expand Down