Add support for many DeviceConfig methods using Settings.Config shadow methods #9076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…w methods Add Shadow method implementations for the following Settings.Config methods: * Settings.Config.getString(...) * Settings.Config.getStrings(...) * Settings.Config.putString(...) * Settings.Config.setStrings(...) * Settings.Config.deleteString(...) The advantage of this approach is that it uses the real DeviceConfig code. As an additional benefit. this also avoids a race condition where calling Settings.Config.getString on Android U could result in an NPE if invoked by a leaking thread in between tests, due to a null RuntimeEnvironment.activityThread member. There are still some limitations, such as no content notifications when DeviceConfig changes, but this also did not work prior to this CL, and can be fixed in a forthcoming CL. Also, add a large subset of the CTS DeviceConfigTest. PiperOrigin-RevId: 633229653
copybara-service
bot
force-pushed
the
piper_631497441
branch
from
4c2d6b7
to
4acc9e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for many DeviceConfig methods using Settings.Config shadow methods
Add Shadow method implementations for the following Settings.Config methods:
The advantage of this approach is that it uses the real DeviceConfig code. As
an additional benefit. this also avoids a race condition where calling
Settings.Config.getString on Android U could result in an NPE if invoked by a
leaking thread in between tests, due to a null
RuntimeEnvironment.activityThread member.
There are still some limitations, such as no content notifications when
DeviceConfig changes, but this also did not work prior to this CL, and can be
fixed in a forthcoming CL.
Also, add a large subset of the CTS DeviceConfigTest.