Force ordering on MemoryLeaksTest to make it deterministic. #9084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_634877599
branch
2 times, most recently
from
4cae2b7
to
5188b01
Compare
copybara-service
bot
force-pushed
the
piper_634877599
branch
from
5188b01
to
6207d10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force ordering on MemoryLeaksTest to make it deterministic.
This test would miss errors when sharding was used, making it
brittle. It also had an issue where if the between test
tests were ordered towards the end of the list, they would
miss out on bugs where static state created once per test class would
leak but not during those two tests. By forcing these tests to be the first
ones that run using alphabetically ordering, we can ensure bugs like that
are caught both internally and on github.