Ensure assertThrows clauses only have one statement. #9180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
reviewed
Jun 13, 2024
robolectric/src/test/java/org/robolectric/junit/rules/TimeoutRuleTest.java
Outdated
Show resolved
Hide resolved
hoisie
approved these changes
Jun 13, 2024
It is ambiguous to have multiple statements in an assertThrows clause. Using such a pattern fails internal google lint checks. This commit removes the unnecessary use of multiple statements in assertThrows.
brettchabot
force-pushed
the
assertThrows
branch
from
e145704
to
51db87d
Compare
MGaetan89
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is ambiguous to have multiple statements in an assertThrows clause. Using such a pattern fails internal google lint checks.
This commit removes the unnecessary use of multiple statements in assertThrows.