Added ContentResolver.getType() shadow implementation and test cases #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, Erich, not sure I understand why this was closed instead of merged? I implemented ShadowContentResolver.getType() and test cases for it. Did I screw something up or is there a better way? |
|
I think it was merged. But it was merged manually and github thinks it is just closed not merged. |
|
Ah, thanks, SuperJugy! |
|
@dbreese I tend to merge things by hand with 'git am' so I can fix minor formatting problems without having to kick a PR back to the submitter. You should still be marked as the author of the PR, but github's UI doesn't always reflect this. |
dlam
pushed a commit
to hulu/robolectric
that referenced
this pull request
Feb 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContentResolver.getType() was not being called properly and was returning null.
See https://groups.google.com/forum/#!topic/robolectric/I5z5N5NH4Pw