WebView.MustOverrideException can be thrown for setJavascriptCanOpenAutomatically #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deException With robolectric 2.2 when we try to set the javaScriptCanOpenWindowAutomaticaly we get the above error. This is because the TestWebSettings class doesn't override and implement this functionality. This patch adds two tests and implements the getter and setters for this functionality.
|
test failure is in SQLLiteLibrary code, I didn't touch any of this code with this patch and was a clean pull of master. |
|
please verify your code once again(or maybe try to rebuild) becase I have created pull request in almost the same time and my build is fine. |
|
I went ahead and merged this manually, but typo'd the issue number in the commit message. Thanks for the pull request! |
|
Cool. I re-ran it localy and it works as expected and there were no udpates from master that I had missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With robolectric 2.2 when we try to set the javaScriptCanOpenWindowAutomaticaly
we get the above error. This is because the TestWebSettings class doesn't
override and implement this functionality. This patch adds two tests and
implements the getter and setters for this functionality.