-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helmfile v0.125.5 fails to build dependencies #1438
Comments
@jheidbrink I think this relaets to #541 and it happens when you tried to concurrently Probably I can enhance helmfile to gain exclusive lock on the local chart before running I'm marking this as a bug |
I agree it's probably an issue with building helm dependencies for the same chart concurrently. I wouldn't say it's a duplicate of #541 though, as that one only happens when killing a previous helmfile process, or when running mulitple helmfile processes simultaneosly. The issue I described always happens. Also, it only got introduced with version 0.125.5, while #541 also affects earlier versions. |
I'm wondering if one could simply remove duplicates in the list of charts to update the dependencies for. |
By the way, our workaround for this is to first update all chart dependencies directly using helm, and then run helmfile with the |
@InspektorWarnebring Thanks. You're correct. I reread my comment before seeing your comment and edited my comment realizing I was wrong! |
@jheidbrink Yes. Implementation-wise, it would have been the best if I could do so. Unfortunately, the Line 928 in 14e2b9e
A short-term fix I managed to build in a timely manner is #1439. I'll keep it open until tomorrow morning and see if I can come up with a better one, and merge it anyway if I had no other idea. |
* Fix race while running `helm dep build` on local chart Fixes #1438
@jheidbrink Merged #1439. It will be released as part of upcoming v0.125.9.
BTW I think I've managed to implement it this way- See the latest commit in the PR :) Thanks for the feedback. |
Versions used: Helmfile 0.125.5 (0.125.4 works alright), Helm 3.2.4
When defining multiple releases for a chart with a dependency, Helmfile fails when updating the dependencies:
The command was run in a fresh clone of the repository.
This is the content of the files involved:
helmfile.yaml:
chart-templates/example-with-dependency/Chart.yaml:
chart-templates/example-with-dependency/requirements.yaml:
chart-templates/example-with-dependency/requirements.lock:
The text was updated successfully, but these errors were encountered: