Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing --reset-values in helm exec #63

Closed
mumoshu opened this issue Mar 23, 2018 · 7 comments
Closed

Forcing --reset-values in helm exec #63

mumoshu opened this issue Mar 23, 2018 · 7 comments

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Mar 23, 2018

Extracted from #60 (comment)

TL;DR; Not specifying --reset-values while calling out helm upgrade --install in the context of Helmfile seems completely wrong to me right now.

Can we just force it?

@mumoshu
Copy link
Collaborator Author

mumoshu commented Apr 27, 2018

For more context on why helm retain previously set values unless you explicitly reset it with --reset-values or override with --set, see helm/helm#1569 (comment)

We actually went from your expected case to this behavior because of community demand. The rationale behind the move was: If user A does a release, and then leaves and the app breaks, user B needs to be able to re-deploy with the same set of configs (and the minimal amount of work). Going to the defaults would be a confusing experience for user B.

This doesn't apply to helmfile, by its nature, as your helmfile.yaml is version-controlled and shared safely across your team as the desired state of your system.

cc/ @sstarcher

@sstarcher
Copy link
Contributor

....This explains exactly why I was noticing some values not update... I can't believe I forgot about this.

I would 100% agree with you that this should be the default. It "might" make sense in some situations to allow the user to disable the flag as the user may only want to update the chart versions, but that could be discussed as a later enhancement.

@mumoshu
Copy link
Collaborator Author

mumoshu commented Apr 27, 2018

Thanks for the confirmation. Yes, I'm open to the future discussion about adding the opt-out flag.
For now, let's start by just forcing --reset-values!

@Stono
Copy link
Contributor

Stono commented May 10, 2018

I really need this, it's pretty critical for me to use helmfile

mumoshu added a commit to mumoshu/helmfile that referenced this issue May 10, 2018
@mumoshu
Copy link
Collaborator Author

mumoshu commented May 10, 2018

@Stono So am I! And here it is: #141

mumoshu added a commit to mumoshu/helmfile that referenced this issue May 10, 2018
mumoshu added a commit to mumoshu/helmfile that referenced this issue May 10, 2018
@mumoshu
Copy link
Collaborator Author

mumoshu commented May 10, 2018

v0.15.0 has been released with the fix for this.

@Stono
Copy link
Contributor

Stono commented May 10, 2018

woo hoo \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants