Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include kustomize binary in helm3-based Docker image #1626

Merged
merged 1 commit into from Dec 28, 2020
Merged

Include kustomize binary in helm3-based Docker image #1626

merged 1 commit into from Dec 28, 2020

Conversation

dalbani
Copy link
Contributor

@dalbani dalbani commented Dec 21, 2020

In order to use the newly included Kustomize Transformers functionality (#1592), I propose to include the kustomize binary in the Docker image.
I understand that it will make the image size significantly larger, but is that a problem?
The alternative would be to provide another flavor of the image, e.g. helm3-kustomize-v0.135.0, but is it worth the hassle?

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Yeah, I believe this makes sense. Let's try and wait until anyone complains.

// I can imagine that anyone may be using the helmfile image as the base for their custom image and not wanting the official image to contain anything that they don't use(i.e. kustomize). But we can't verify that without releasing and waiting for complaints :)

@mumoshu mumoshu merged commit dd5bc46 into roboll:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants