New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process feedback for pr 1983 #1992

Merged

mumoshu merged 2 commits into roboll:master from paichinger:process-feedback-for-pr-1983

Oct 21, 2021

Contributor

paichinger commented Oct 21, 2021

This is a follow-up PR to deal with the feedback in #1983

Peter Aichinger added 2 commits

October 21, 2021 10:23


          Guard collectNeeds-method against infinite recursion.

97072ac


          Also check for namespace and kubecontext when collecting needs.

0df41da

paichinger mentioned this pull request

Add support for transitive dependencies (needs). #1983

Merged

mumoshu approved these changes

View reviewed changes

Collaborator

mumoshu left a comment

LGTM. Thanks for your efforts @pjotre86 ☺️

mumoshu merged commit 9354c38 into roboll:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment