-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding secret processing for helmfile via helm-secrets plugin #53
Conversation
fixes #41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nits - I appreciate it if you could address these but please feel free to ask me if you are short on time 👍
helmexec/helmexec.go
Outdated
@@ -9,4 +9,6 @@ type Interface interface { | |||
SyncRelease(name, chart string, flags ...string) error | |||
DiffRelease(name, chart string, flags ...string) error | |||
DeleteRelease(name string) error | |||
|
|||
SecretDecrypt(name string) (string, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nit but I slightly prefer DecryptSecret
so that it looks consistent with other functions!
README.md
Outdated
|
||
The `secrets` parameter in a `helmfile.yaml` causes the [helm-secrets](https://github.com/futuresimple/helm-secrets) plugin to be executed to decrypt the file. | ||
|
||
Under the covers Helmfile is simply using the `helm secrets` plugin, so that needs to be installed prior. For Helm 2.3+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I'm not a native English user, probably:
Under the covers, Helmfile uses the helm-secrets plugin and therefore you need to install it prior to start using this feature.
would sound a bit more natural(to me 😉).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stole this from the previous block on helm-diff ;)
state/state.go
Outdated
return nil, err | ||
} | ||
|
||
release.generatedSecrets = append(release.generatedSecrets, valfileRendered) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer calling it generatedValues
rather than generatedSecrets
, because what you append to it here is actually a valfile
generated from a secrets file.
@mumoshu addressed |
Awesome! Thank you very much for your continuous support |
No description provided.