Add kubectl and jq to Dockerfile #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jake Hill <jake@naphta.uk>
|
Thanks! Checksum verification would be appreciated if possible. Also, I thought version skew supported by kubectl was plus and minus 1 K8s minor vers. That is, to correctly support K8s 1.15(latest) and 1.13(oldest, maintained minor ver), shouldn't we use kubectl v1.14.x? |
|
Yep 1 forward/back seems to be the version skew. I'll move it to be hardcoded at the latest 1.14.x minor version. EDIT: I've made the change now. |
…rsion Signed-off-by: Jake Hill <jake@naphta.uk>
|
@mumoshu Just wondering if there's plans to run a release soon (looking to see the docker image built!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in issue: #789 and #792.
For now I've made it contact kubernetes for the latest version every time, looking at the implementation of the helm installation would you prefer for it to be a hardcoded and checksum confirmed version added?