Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all formatters working - task list #20

Closed
8 of 17 tasks
destogl opened this issue Aug 25, 2021 · 2 comments
Closed
8 of 17 tasks

Make all formatters working - task list #20

destogl opened this issue Aug 25, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@destogl
Copy link
Collaborator

destogl commented Aug 25, 2021

  • ament_cppcheck - done in Change extension of header files. #24

    • rename *.h files into *.hpp files
    • enable in pre-commit config
    • enable in ROS-linters
  • ament_cpplint

    • exchange #pragma once if #ifndef ... header guard (needs discussion)
      • remove build/header_guard flag from the ament_cpplint configuration
      • remove from ROS-linters
    • Use " instead <> around private headers (needs discussion) - already used in some places, e.g., smacc_updatable.h
      • remove build/include_order flag from config
      • remove from ROS-linters
    • Do not use namespace using-directives. Use using-declarations instead.
      • remove build/namespaces flag from config
      • remove from ROS-linters
    • Replace use of unsigned long with something else (uint64?)
      • remove runtime/int flag from config
      • remove from ROS-linters
@brettpac
Copy link
Collaborator

Ok, so let's just do the uint64 thing and kill this ticket please.

@destogl
Copy link
Collaborator Author

destogl commented Sep 30, 2021

or we can simply leave it open for some better times.

@destogl destogl removed their assignment Sep 30, 2021
@destogl destogl added the help wanted Extra attention is needed label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants