-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #29
Merged
Merged
Refactoring #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vasar007
requested changes
Nov 26, 2018
Co-Authored-By: Rexarrior <Rexarrior@yandex.ru>
Co-Authored-By: Rexarrior <Rexarrior@yandex.ru>
Remove redundand brackets
add TODO comment
Add with expression
Vasar007
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority/high
High issue priority
type/code maintenance
New feature/requirement that focuses on improving architecture, realization and code style
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Рефакторинг с целью оптимизации и интеграция решения второй задачи.
Описание
Механизм взаимодействия с базой данных переписан с целью универсализации и повышения гибкости.
Добавлен инструмент для заполнения базы из файлов json и jsonlines.
Модели данных соответствуют описанным в issue.
Выполнено разбиение файла ksrf_models на несколько файлов, по одному на каждую модель.
Добавлено несколько сущностей в all в init
Добавлено несколько вариантов функции Initialize в init
Тестовый план
С помощью этого кода выполнена загрузка новых файлов в бд. Ошибок не выявлено.
В случае проведения дополнительного тестирования рекомендуется посмотреть на примеры использования
Связанные задачи
DatabaseWrapper.put_data теперь может использоваться для решения задач по обновлению\установке атрибутов ( #9)
Часть решения этой задачи
Поддержка формата jsonlines решает проблему слишком больших данных. Проверено на объеме в 8 гб. (closes #25 )