Fix op25 errors #659
Merged
Fix op25 errors #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! |
|
I believe these options should really be exposed and settable in the configuration file. I know the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the source of the op25_audio::hostname_to_ip() getaddrinfo: Name or service not known errors on startup that started in November. The commit after the one below lost the the default "127.0.0.1" value.
https://github.com/robotastic/trunk-recorder/blob/fa72e5879328646f46d57ad537320788045d7c16/trunk-recorder/recorders/p25_recorder_decode.cc