Include boost/filesystem header #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is weird - is this with Arch Linux? |
|
This is with Arch Linux. I see the error on an ARM SBC and in that container. I also ran across an issue with Arch's spdlog not bundling fmt. The suggested solution from a quick search was to define SPDLOG_FMT_EXTERNAL in cmake. I wrapped it in a test for the directory the header would be in so as to not break anyone else. For reference see this old issue. |
|
Cool! thanks for tracking this down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this include I get an error that boost::filesystem::create_directories is not declared while compiling this file.