Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set d_call to null to prevent potential use after free #739

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Set d_call to null to prevent potential use after free #739

merged 1 commit into from
Dec 4, 2022

Commits on Dec 3, 2022

  1. Set d_call to null to prevent potential use after free

    plugman_audio_callback in p25_recorder_decode is sometimes
    call when d_call is an invalid pointer. This seems to be some form
    of race condition where d_call has been freed immediately
    before the audio callback is called, causing a segmentation fault
    in the simplestream plugin on line 63 (`call->get_system()`).
    By setting d_call to null when `p25_recorder_decode::stop()`
    is called,  we can check for it being invalid before a plugin
    ever sees it, preventing a use-after-free segmentation fault.
    galenguyer committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    4801991 View commit details
    Browse the repository at this point in the history