Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dropped samples logging. #745

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

tadscottsmith
Copy link
Contributor

When an inactive P25 call is stopped, occasionally there can still be a single tagged sample used to pass the terminate tag that transmission_sink attempts to process, resulting in a "current_call is null" error. This PR would make the log trace-level if only a single sample is dropped, and make it an error-level when more samples are dropped.

[2022-12-13 17:36:42.010653] (info)   [ramsey]  923C     - Stopping P25 Recorder Num [1] TG:           EMSMRCC (      2142)   Freq: 852.662500 MHz    TDMA: false     Slot: 0 Hz Error: -926
[2022-12-13 17:36:42.011798] (info)   [ramsey]  923C     TG: 2142     Freq: 852.662500 MHz    - Transmission src: 121148 pos: 0 length: 1.08
[2022-12-13 17:36:42.012359] (error)   [ramsey] 923C     TG: 2142     Freq: 852.662500 MHz    Dropping samples - current_call is null        Rec State: available   Since close: 1

@robotastic robotastic merged commit 7ad2d92 into robotastic:master Dec 20, 2022
@robotastic
Copy link
Owner

I like it! not a huge issue if we don't get all the TDUs.

@tadscottsmith tadscottsmith deleted the dropped-samples-logging branch April 26, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants