Ignore missing files #796
Merged
Ignore missing files #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, trunk-recorder tries to combine two wav files into one, but one of them doesn't actually exist. This fixes the issue by checking for file existance before sending files to sox - which will preserve any audio that exists in the remaining file.
|
Interesting! I wonder what is causing the missing files... let me know if you have any clues. Maybe there is some delay in writing. Either way, this is a good error check. Thanks! |
|
Not sure if if's just me, but it looks like to get this to compile on Ubuntu and pass the github Buildx check. |
Merged
|
Should be fixed, thanks to @taclane |
|
Or more accurately - a similar, but different bug was also addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, trunk-recorder tries to combine two wav files into one, but one of them doesn't actually exist. This fixes the issue by checking for file existence before sending files to sox - which will preserve any audio that exists in the remaining file.
This situation was causing a
Failed to combine recordings, see above error. Make sure you have sox and fdkaac installed.error occasionally, and resulted in the audio not being properly saved.