Include TDMA slot number in transmission_sink(). #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't look like all the changes made it into the PR - I can take a look at this tonight and move the other parts in too. I might switch it around and just have Transmission sink pull the TDMA Slot from the Call that is passed. |
|
This was the the full change that a couple of people were using yesterday. Since you already had a transmission_sink::start_recording(Call *call, int slot) setup for DMR, it was just a matter of using the same function for the correct TDMA slot. It should also work to grab the slot within transmission sink and get rid of the overloaded star_recording() function. |
|
Ahhh!!! Genius. That is what I get for trying to look at it before coffee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue where P25P2 TDMA transmissions may not be correctly recorded if the same talk group and frequency are being utilized on different TDMA slots in short intervals.