New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdio-scanner: Fix systemID to match the datatype used in rdio-scanner #860

Merged

robotastic merged 1 commit into robotastic:master from USA-RedDragon:rdio-scanner-config-fix

Nov 12, 2023

Contributor

USA-RedDragon commented Nov 12, 2023 •

edited

rdio-scanner uses a Go uint (uint32_t is the C equivalent) to store the system ID: https://github.com/chuot/rdio-scanner/blob/c9c4ea4530f906dc2f1a9d67706ca987e5f82131/server/system.go#L29

This also prevents 47460b1 from making this doc wrong, as the current state of the code requires systemID to be a string:

trunk-recorder/docs/Plugins.md

Line 50 in 713049a

    
           | systemId  |    ✓     |               | number | System ID for Rdio Scanner.                                  |

trunk-recorder/docs/Plugins.md

Line 66 in 713049a

"systemId": 411


          rdio-scanner: Fix systemID to match the datatype used in rdio-scanner

d15403e

rdio-scanner uses a Go uint (uint32_t is the C equivalent) to store the system ID: https://github.com/chuot/rdio-scanner/blob/c9c4ea4530f906dc2f1a9d67706ca987e5f82131/server/system.go#L29

This also prevents 47460b1 from making this doc wrong, as the current state requires a string: https://github.com/robotastic/trunk-recorder/blob/713049ad540423392db5ed8b7fba3507bb0c0fea/docs/Plugins.md?plain=1#L50

Owner

robotastic commented Nov 12, 2023

Good catch!

robotastic merged commit 6d81c49 into robotastic:master

1 check passed

USA-RedDragon deleted the rdio-scanner-config-fix branch

November 12, 2023 14:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment