Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve duplicate detection for p25p2 TDMA #866

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

taclane
Copy link
Contributor

@taclane taclane commented Nov 14, 2023

Multi-site duplicate detection currently requires both calls to have the same TDMA slot number, even across different systems or frequencies. Depending on the slot assignments from the system controllers, there is only a 50% chance to correctly identify duplicate calls across TDMA networks.

Removing the line below requiring the same TDMA status and slot essentially doubles the reliability of dupe detection on these systems.

if ((call->get_phase2_tdma() == message.phase2_tdma) && (call->get_tdma_slot() == message.tdma_slot)) {

trunk-recorder/main.cc Outdated Show resolved Hide resolved
Co-authored-by: Eric Tendian <erictendian@gmail.com>
@taclane
Copy link
Contributor Author

taclane commented Nov 14, 2023

Following up on this, removing this line from the original multisite implementation was discussed back in June.

It was not doing anything besides occasionally preventing duplicate detection on TDMA systems.

@taclane
Copy link
Contributor Author

taclane commented Nov 15, 2023

Streamlined the console log entry per Discord feedback.

@robotastic robotastic merged commit 0ba0614 into robotastic:master Nov 15, 2023
1 check passed
@taclane taclane deleted the multisite-v2.1 branch November 16, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants