Parse Motorola Patch Group Grant service options #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - that looks good, merging it in I am confused though - this same code gets called for GRANTS and PATCHES? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service options (encryption etc.) for Motorola Patch Group Grants were not being parsed. Added this. They are not present in the update version. The patch service options already commented out relate to the 'moto patch group add' message so I removed these lines completely.
Just taking another look at this code, we parse the Patch Group as being equivalent to a Talkgroup, when it's specifying that it should also be patched to the target talkgroups listed for that patch group. We could also get a call to a talkgroup with the same number that should not be patched, unlikely as this seems.
I do sometimes see some inconsistent behaviour with regards to patched call handling and the talkgroup that trunk recorder lists as 'the' talkgroup that it was on, and talkgroup mismatch errors between the trunking/recorder.
Hence it may be worth being more diligent in the way these are tracked.