Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust integer config values to double #876

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

taclane
Copy link
Contributor

@taclane taclane commented Nov 28, 2023

The value for squelch_db was previously read from the config file as a double, and is later used as a double during recorder setup. Updating the default value would restore this behavior, and avoid truncating downward to an integer.

The value for callTimeout has previously been read from the config file as an integer, but the json library is now truncating the value instead of rounding. Reports such as #875, and similar discussions on the discord, seem to indicate that users have been setting decimal values for this under one second, and the fact that it is now truncating down to 0 is causing multiple unexpected issues.

Much like other call-shaping parameters (minDuration, maxDuration, and minTransmissionDuration), callTimeout should also allow decimal values. Adjusting the type in the config struct would correct this.

@robotastic
Copy link
Owner

Agreed - the difference between rounding and truncating has seemed to cause some real issues. This is a good approach to address that.

@robotastic robotastic merged commit 2ad3656 into robotastic:master Nov 29, 2023
1 check passed
@taclane taclane deleted the config-fix branch December 13, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants