Control Channel Retune Handling #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotastic
added a commit
that referenced
this pull request
May 3, 2024
This reverts commit a3eda60.
robotastic
added a commit
that referenced
this pull request
May 3, 2024
|
Could you make this PR against the v5.0 branch instead? It looks like it is changing some of the functions that moved around in the newer branch, making it trickier to merge in the future. |
|
Sure! I'll give that a shot tomorrow. I know the PR looks a lot nastier than it really is because I had to move the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help address the issue of the control channel trying to retune to an active traffic channel.
Adds an INVALID_CC_MESSAGE message type for messages that are not correctly parsed and does not count them for control channel msgs/sec. Note that UNKNOWN messages are still counted in cases of correctly parsed messages with an unknown opcode.
Adds a TDULC message type when the parser receives a TDU with Link Control on a channel it believes should be a control channel. The specs indicate there should not be Link Control messages on an active control channel, so this immediately causes a retune to the next available control channel.