Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fast_ignore instead of git ls-files #9

Merged
merged 4 commits into from Jun 6, 2020

Conversation

utkarsh2102
Copy link
Contributor

Hello,

This PR does two of the following things:

  • It uses fast_ignore instead of git ls-files because:

    • this way we can drop the unnecessary dependency on git.
    • use what this project is intended to do ❤️
    • ...because why not? :)
  • Adds /vendor/ to the .gitignore file.
    That is because when bundle install is run, it creates a vendor/ directory which should not be committed.

Given that these are two different things, I had them committed separately.
If it makes sense, don't squash them while merging either \o/

Thanks for your work on this! 💯

@utkarsh2102 utkarsh2102 changed the title Use fast ignore Use fast_ignore instead of git ls-files Jun 3, 2020
fast_ignore.gemspec Outdated Show resolved Hide resolved
@robotdana
Copy link
Owner

Perfect thank you.

I'm just cleaning up some other fixes and should have a release in half an hour or so

@robotdana robotdana merged commit 91a9361 into robotdana:master Jun 6, 2020
@utkarsh2102
Copy link
Contributor Author

Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants