Use fast_ignore instead of git ls-files
#9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR does two of the following things:
It uses
fast_ignore
instead ofgit ls-files
because:Adds
/vendor/
to the.gitignore
file.That is because when
bundle install
is run, it creates avendor/
directory which should not be committed.Given that these are two different things, I had them committed separately.
If it makes sense, don't squash them while merging either \o/
Thanks for your work on this! 💯