Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not call methods which uses @keyword decorated methods to change the keyword name from the library instance when extending library #1001

Closed
aaltat opened this issue Nov 23, 2017 · 1 comment · Fixed by #1003
Closed

Can not call methods which uses @keyword decorated methods to change the keyword name from the library instance when extending library #1001

aaltat opened this issue Nov 23, 2017 · 1 comment · Fixed by #1003
Labels
bug priority: high rc 2

Comments

@aaltat
Copy link
Contributor

aaltat commented Nov 23, 2017

When doing this:

from SeleniumLibrary import SeleniumLibrary


lib = SeleniumLibrary()
print lib.keywords.get('get_webelements')

the print should not display False, instead it should return the method. Now the print lib.keywords.get('Get WebElements') return the method, which is hard to use in Python side.

This needs fixing in the robotframework/PythonLibCore#2 side
@aaltat aaltat added this to the v3.0.0 milestone Nov 23, 2017
aaltat added a commit to aaltat/SeleniumLibrary that referenced this issue Nov 27, 2017
@aaltat
Updates robotlibcore to 1.0rc3 version.
d3170f5 
This fixes problem when calling keywords methods, which uses the
@Keyword decorator to change the keyword name, from the library
instance when extending library

Fixes robotframework#1001
@aaltat aaltat mentioned this issue Nov 27, 2017
Merged
aaltat added a commit that referenced this issue Nov 27, 2017
@aaltat
Updates robotlibcore to 1.0rc3 version. (#1003)
ff380c1 
This fixes problem when calling keywords methods, which uses the
@Keyword decorator to change the keyword name, from the library
instance when extending library

Fixes #1001
aaltat added a commit to aaltat/SeleniumLibrary that referenced this issue Nov 27, 2017
@aaltat
Tests for making sure that keywords can be used in programatic way
b9266ef 
Tests for robotframework#1001
@aaltat aaltat mentioned this issue Nov 27, 2017
Merged
@aaltat aaltat reopened this Nov 27, 2017
aaltat added a commit that referenced this issue Nov 28, 2017
@aaltat
Tests for making sure that keywords can be used in programmatic way (#…
f5e2bad 
…1004)

* Tests for making sure that keywords can be used in programatic way

Tests for #1001
@aaltat aaltat closed this as completed Nov 28, 2017
@aaltat aaltat changed the title Cat not call methods which uses @keyword decorated methods to change the keyword name from the library instance when extending library Can not call methods which uses @keyword decorated methods to change the keyword name from the library instance when extending library Nov 28, 2017
@pekkaklarck
Copy link
Member

This was a regression during 3.0 development so it doesn't really belong to final 3.0 scope.

@pekkaklarck pekkaklarck removed this from the v3.0.0 milestone Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority: high rc 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates robotlibcore to 1.0rc3 version. aaltat/SeleniumLibrary
2 participants
@pekkaklarck @aaltat