New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirements.txt and README.rst #6
Conversation
chanita
commented
Mar 30, 2019
- Add robotframework-seleniumlibrary as a dependency in requirement.txt.
- Update README.rst to use pip install -r requirement.txt
Use pip install -r requirements.txt to install dependencies
Thank you for the enhancement. All looks good and PR is merged. |
Are you sure this is a good idea?
|
For me requirements.txt feels better, although I agree that the project is not meant for users like me. Instead project is meant for users that are new in Python or/and Robot Framework. For those users the txt file can feel even stranger. When you did say it out loud, I am starting to second guess me. Also I can not decide what would be better. Opinions? |
If requirements.txt is used, these additional changes are needed:
In my opinion the above isn't worth the effort and I'm afraid instructions would end up being more complicated than they used to be. What I'd do instead:
|
@aaltat What do you think about my comment above? The current requirements.txt with dev requirements is not a good idea at all. If you have nothing against it, I'll change installation instructions to contain just |
Sorry, I did forget that I did promise to fix this. But I think you are right and |