-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #65: java.lang.IllegalStateException: Duplicate key stop_remote_server #66
Conversation
…iple times Also extends tests to cover this behaviour.
Hi anyone who can review and merge this PR? We are also experiencing this error when running multiple tests |
I can also release a fork of this in Maven Central under my namespace, but I would prefer this being maintained of course. |
https://repo1.maven.org/maven2/io/github/lasselindqvist/jrobotremoteserver/4.2.0/ is a deployed version with this fix. I can also deploy any other needed fixes to this project in https://github.com/lasselindqvist/jrobotremoteserver |
@lasselindqvist Sorry, have missed this PR completely somehow. If you're interested, you can also get rights to this repo to maintain the library. Related to PR there's conflict now, that prevents merging. |
Maybe cb0de38 already included these fixes, just without the tests. |
hello, are there any update on this MR? I am facing the same issue and it is blocking me too |
Maybe, but the commit you mentioned was not released (commit on DEC2022 but latest release is from MAR2022)... |
I did release this fix to Maven Central if someone needs it https://mvnrepository.com/artifact/io.github.lasselindqvist/jrobotremoteserver |
@lasselindqvist @Leemur89 As mentioned in the comments, this can't be merged without conflict being fixed. |
Yes. Like said, this has been included in the code base already without the tests, so I will close now. Those who want a maintained released version from Maven Central can use the fork if they wish. |
@lasselindqvist I also suggested that you can be maintainer in this repo that's kind of easier to find, but with open source world forks can be done also. |
Fixes #65
Fix get_library_information when called multiple times
Also extends tests to cover this behaviour.