Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #65: java.lang.IllegalStateException: Duplicate key stop_remote_server #66

Closed

Conversation

lasselindqvist
Copy link

Fixes #65
Fix get_library_information when called multiple times
Also extends tests to cover this behaviour.

…iple times

Also extends tests to cover this behaviour.
@mluyun
Copy link

mluyun commented Jun 28, 2022

Hi anyone who can review and merge this PR? We are also experiencing this error when running multiple tests

@lasselindqvist
Copy link
Author

I can also release a fork of this in Maven Central under my namespace, but I would prefer this being maintained of course.

@lasselindqvist
Copy link
Author

https://repo1.maven.org/maven2/io/github/lasselindqvist/jrobotremoteserver/4.2.0/ is a deployed version with this fix. I can also deploy any other needed fixes to this project in https://github.com/lasselindqvist/jrobotremoteserver

@Hi-Fi
Copy link
Collaborator

Hi-Fi commented Dec 12, 2022

@lasselindqvist Sorry, have missed this PR completely somehow. If you're interested, you can also get rights to this repo to maintain the library.

Related to PR there's conflict now, that prevents merging.

@lasselindqvist
Copy link
Author

@lasselindqvist Sorry, have missed this PR completely somehow. If you're interested, you can also get rights to this repo to maintain the library.

Related to PR there's conflict now, that prevents merging.

Maybe cb0de38 already included these fixes, just without the tests.

@Leemur89
Copy link

Leemur89 commented Apr 7, 2023

hello, are there any update on this MR? I am facing the same issue and it is blocking me too
thanks :)

@Leemur89
Copy link

@lasselindqvist Sorry, have missed this PR completely somehow. If you're interested, you can also get rights to this repo to maintain the library.
Related to PR there's conflict now, that prevents merging.

Maybe cb0de38 already included these fixes, just without the tests.

Maybe, but the commit you mentioned was not released (commit on DEC2022 but latest release is from MAR2022)...
Do you know if people are still maintaining this repo?

@lasselindqvist
Copy link
Author

@lasselindqvist Sorry, have missed this PR completely somehow. If you're interested, you can also get rights to this repo to maintain the library.
Related to PR there's conflict now, that prevents merging.

Maybe cb0de38 already included these fixes, just without the tests.

Maybe, but the commit you mentioned was not released (commit on DEC2022 but latest release is from MAR2022)... Do you know if people are still maintaining this repo?

I did release this fix to Maven Central if someone needs it https://mvnrepository.com/artifact/io.github.lasselindqvist/jrobotremoteserver
Of course it would be nicer if this was maintained still.

@Hi-Fi
Copy link
Collaborator

Hi-Fi commented Jul 26, 2023

@lasselindqvist @Leemur89 As mentioned in the comments, this can't be merged without conflict being fixed.

@lasselindqvist
Copy link
Author

@lasselindqvist @Leemur89 As mentioned in the comments, this can't be merged without conflict being fixed.

Yes. Like said, this has been included in the code base already without the tests, so I will close now. Those who want a maintained released version from Maven Central can use the fork if they wish.

@Hi-Fi
Copy link
Collaborator

Hi-Fi commented Jul 26, 2023

@lasselindqvist I also suggested that you can be maintainer in this repo that's kind of easier to find, but with open source world forks can be done also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalStateException: Duplicate key stop_remote_server
4 participants