Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of rotation parameters in Cartesian controller #1

Open
PeterBowman opened this issue Sep 9, 2017 · 0 comments
Open

Fix order of rotation parameters in Cartesian controller #1

PeterBowman opened this issue Sep 9, 2017 · 0 comments
Assignees
Projects

Comments

@PeterBowman
Copy link
Member

PeterBowman commented Sep 9, 2017

There is a nasty FIXME annotation left in:

// FIXME: un-shuffle coordinates
velocities[3] = xdotd_rpy[4]; // [rad/s]
velocities[4] = -xdotd_rpy[5];
velocities[5] = xdotd_rpy[3];

This is due to a mismatch between [rotx,roty,rotz] coordinates in the robot API and the controller, which may actually originate at KinRepresentation::decodeVelocity (this is the encodeX part):

https://github.com/roboticslab-uc3m/kinematics-dynamics/blob/30d59e2acfd1549e7b0e7d064cb76407a0fc02db/libraries/KinematicRepresentationLib/KinematicRepresentation.cpp#L250-L264

See also:

  • roboticslab-uc3m/amor-api@4d60fed96fbc833a7f1338a7a84a887e29ba134c
  • roboticslab-uc3m/amor-api@2aabe80c9c7664cc8ecfae626e3315a54d3987b2
@PeterBowman PeterBowman self-assigned this Sep 9, 2017
@PeterBowman PeterBowman transferred this issue from roboticslab-uc3m/kinematics-dynamics Dec 3, 2023
@PeterBowman PeterBowman added this to To do in [AMOR] via automation Dec 3, 2023
@PeterBowman PeterBowman changed the title [AmorCartesianControl] Fix order of rotation parameters Fix order of rotation parameters in Cartesian controller Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
[AMOR]
  
To do
Development

No branches or pull requests

1 participant