Skip to content
This repository has been archived by the owner on Sep 29, 2020. It is now read-only.

Unused initial g in both test scripts #34

Closed
Ganimed opened this issue Oct 9, 2015 · 10 comments
Closed

Unused initial g in both test scripts #34

Ganimed opened this issue Oct 9, 2015 · 10 comments

Comments

@Ganimed
Copy link
Contributor

Ganimed commented Oct 9, 2015

Hi all,

in both testing scripts "forwardDynamicsConsistencyTest.m" and "integrateForwardDynamics.m" there is an initial gravity vector created for the control torques with,

gInit = wbm_generalisedBiasForces(R_b,p_b,params.qjInit,zeros(25,1),zeros(6,1));

but will never used. For the time-dependent parameter tau it will be used the zeros-function instead of gInit. Is zeros in this case just an initial dummy?
I've found this also in the forwardDynamics function at line 54. Internally g will be calculated but afterwards it will never used or returned.
Can somebody explain me what was the intention, the thought, to calculate there at these places "g" and "gInit"?
Thanks.

@traversaro
Copy link
Contributor

I guess @naveenoid is the author of the script, so he is the right person to reply!

@Ganimed
Copy link
Contributor Author

Ganimed commented Oct 9, 2015

Ok, I will do that. Thanks.

@traversaro
Copy link
Contributor

Feel free to update this issue, so everybody can get this info!

@Ganimed
Copy link
Contributor Author

Ganimed commented Oct 9, 2015

I will do that when I've got the information.

By the way, in the folder matlab-src there is the folder "worker_functions" where inside are some nice functions for general purposes. In my opinion it is more meaningful if the folder "worker_functions" is renamed into "toolbox". Then everybody understand what is inside.

@traversaro
Copy link
Contributor

"toolbox" is a bit overloaded in matlab context. I would personally prefer something like "utils".

@Ganimed
Copy link
Contributor Author

Ganimed commented Oct 9, 2015

I understand. "utils" is also a good option. We will see ...

@Ganimed
Copy link
Contributor Author

Ganimed commented Oct 9, 2015

"utilities" or just "tools" is also an option ...

@naveenoid
Copy link
Contributor

Is this still a problem? I thought it was discussed in detail in person? The gInit was used in one of the simulations to set the torque compensating gravity. Im closing this issue for now since we have an overload of others.

@Ganimed
Copy link
Contributor Author

Ganimed commented Oct 22, 2015

It was still confusing me, but now I understand. So you used it just temporarily for another simulation. Thanks for the info.

@traversaro
Copy link
Contributor

For the kinematic testing cleanup that I am doing for solving #30 , I remove the unused vector gInit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants