Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a getter for the list of ordered steps #5

Closed
S-Dafarra opened this issue Feb 1, 2018 · 1 comment
Closed

Implement a getter for the list of ordered steps #5

S-Dafarra opened this issue Feb 1, 2018 · 1 comment

Comments

@S-Dafarra
Copy link
Collaborator

Right now, in orderSteps we generate a vector of ordered steps. This vector contains iterators to the StepList provided as input to the FeetInterpolator class. This allowed to avoid copies of Step objects, but if we need to share information on the list of ordered steps, passing iterators does not seem to be the best solution. This problem arose when we had the need of generating another set of references (see #3). In addition, the starting position of the feet is not included in this vector, which makes its semantic a bit unclear.
We should try to implement an efficient getter method to retrieve the information about the order of the steps, stating clearly whether the initial feet positions are included or not.

cc. @GiulioRomualdi

@S-Dafarra
Copy link
Collaborator Author

After #15 and #17, this is no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant