Automatically add rotated driver vision to Shuffleboard #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobtseattle
reviewed
Mar 11, 2023
| @@ -74,6 +77,10 @@ public Subsystems() { | |||
| // YUYV only: | |||
| // 2304x1296, 2304x1536 | |||
| driverVisionCamera.setResolution(160, 120); | |||
There was a problem hiding this comment.
We might consider starting with a higher resolution so we have it fully vetted for bandwidth problems as soon as we can. I believe the off season FMS is setup to limit bandwidth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low priority, also haven't tested on bot (just ran in sim with a connected camera). Still unsure about the tab name and haven't checked that the rotation's the right way, but I thought I'll throw this out here.to review and test at some point.