Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #18

Closed
emilyxzhou opened this issue Aug 25, 2020 · 3 comments
Closed

Fix flaky tests #18

emilyxzhou opened this issue Aug 25, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@emilyxzhou
Copy link
Contributor

The integration tests sometimes fail when executed in the Docker-based action, usually with the error message "AttributeError: CordialManager instance has no attribute '_aws_client'". Although this error is resolved upon re-running the action, the tests should be fixed so we can be sure that errors are caused by modifications to the code, and not the tests themselves.

@emilyxzhou
Copy link
Contributor Author

This issue hasn't appeared since we've made some major changes to the CI workflow, so I'm closing it for now.

@audrow
Copy link
Contributor

audrow commented Sep 23, 2020

I saw this again when trying a different way of starting the CI. I think that the tests don't have enough time between running them, so their is some cross-contamination between tests.

@audrow
Copy link
Contributor

audrow commented Sep 23, 2020

I'm going to close this again as docker run seems to get around the flaky tests, altough I'm not sure why. We can reopen if we test failures popping up again with docker run.

@audrow audrow closed this as completed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants