Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should fail on non-lowercase package names #154

Open
virtuald opened this issue Jan 19, 2022 · 1 comment
Open

Should fail on non-lowercase package names #154

virtuald opened this issue Jan 19, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@virtuald
Copy link
Member

A user had an issue on Windows 10, Python 3.9, where pip installed the package by making all directories lowercase. We should fail when we see that.
virtuald referenced this issue in robotpy/robotpy-ctre Jan 20, 2022
@virtuald
Make all CTRE packages lowercase
d793cc3 
- Causes issues on Windows apparently?
@auscompgeek
Copy link
Member

It's generally a bad idea to have uppercase in module names anyway, so being opinionated here is probably a good idea to avoid cross-platform issues.

@auscompgeek auscompgeek added enhancement New feature or request good first issue Good for newcomers labels Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@auscompgeek @virtuald