Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PathPlannerLib SwerveAutoBuilder, FollowPathWithEvents, etc. #10

Open
NeilTheFisher opened this issue Mar 5, 2023 · 2 comments
Open

Comments

@NeilTheFisher
Copy link

Problem description

It looks like robotpy-pathplannerlib is missing some vital classes belonging to the original PathPlannerLib like SwerveAutoBuilder. However, I do see header files inside the locally installed package which hints incompleteness.

I'd like to use these classes ASAP. I assume an edit to the gen/ files is what would be required.

image

Operating System

Windows, RoboRIO

Installed Python Packages

No response

Reproducible example code

No response

@NeilTheFisher
Copy link
Author

NeilTheFisher commented Mar 5, 2023

I see they were left out of this PR:
image

@virtuald
Copy link
Member

virtuald commented Mar 6, 2023

This was discussed on gitter, but it would be very challenging to use these classes as-is, because RobotPy uses a forked version of the commands library, and doesn't make it available to link to. I'd rather one of the following to occur:

  • Refactor the C++ code such that it doesn't require commands (but could easily be used from one), ideally submit that upstream, and then we wrap the underlying code here and use it from a thin python command layer
  • Rewrite the C++ code in python (looks like it's just a lot of glue code?) and submit a PR here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants