Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add working SimpleWatchdog #141

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Add working SimpleWatchdog #141

merged 2 commits into from
Mar 14, 2019

Conversation

auscompgeek
Copy link
Member

This restores SimpleWatchdog, with appropriate code to use it correctly in magicbot test mode and AutonomousModeSelector.

virtuald
virtuald approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@virtuald virtuald left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you fix the formatting error. Sorry about breaking it originally, I thought the tests would have caught something like that.

... I also thought I had tested autonomous mode, but clearly that didn't happen.

@auscompgeek auscompgeek merged commit 4cbf39e into master Mar 14, 2019
@auscompgeek auscompgeek deleted the simple-watchdog branch March 14, 2019 07:00
@CrispyBacon1999 CrispyBacon1999 mentioned this pull request Mar 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virtuald virtuald virtuald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@auscompgeek @virtuald